Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements on 1-Wire driver and configs #1013

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Improvements on 1-Wire driver and configs #1013

merged 1 commit into from
Nov 22, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Add sanity check for missing UART defined to use.
  • Improve headers inclusion on several files.
  • Correct comments on target config files.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes
Improvements on 1-Wire driver and configs
bcfe4fa 
- Add sanity check for missing UART defined to use.
- Improve headers inclusion on several files.
- Correct comments on target config files.

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes added Type: enhancement Series: STM32xx Everything related specifically with STM32 targets labels Nov 22, 2018
@nfbot
Copy link
Member

nfbot commented Nov 22, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 1a19f1e into nanoframework:develop Nov 22, 2018
@josesimoes josesimoes deleted the work-one-wire branch November 22, 2018 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot