Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pin mapping and fixes #70

Merged
merged 4 commits into from
Jul 2, 2019

Conversation

AdrianSoundy
Copy link
Member

Description

Add Gpio class to allow the naming of Pins instead of using a number
Added a Get/Set FunctionPin() to return or Set the current pin for a function mapping.
Added ADC constants to DeviceTypes
Fixed Typo - SPI_MISI

Motivation and Context

  • Resolves nanoframework\Interpreter#1288

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy[email protected]

Add Gpio class to allow the naimg of Pins instead of using a number
Added a GetFunctionPin() to return the current pin for a function mapping.
Added ADC constants to DeviceTYpes
Fixed a typo on SPI_MISO
Remove dependency of GPIO assembly
Requires latest firmware image
@nfbot
Copy link
Member

nfbot commented Jul 2, 2019

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes
Copy link
Member

SonarCloud failing on lack of coverage. Ignoring.

@josesimoes josesimoes added the Type: enhancement New feature or request label Jul 2, 2019
@josesimoes josesimoes merged commit 0dc3081 into nanoframework:develop Jul 2, 2019
@AdrianSoundy AdrianSoundy deleted the Update_pin_mapping branch July 9, 2019 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants