Skip to content

Commit

Permalink
Merge branch 'teamrole'
Browse files Browse the repository at this point in the history
  • Loading branch information
jhrv committed Feb 20, 2025
2 parents d5d4a02 + 5699947 commit 1d55260
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion internal/reconcilers/google/gcp/reconciler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ func TestReconcile(t *testing.T) {
t.Errorf("expected role id %q, got %q", expectedTeamRoleId, payload.RoleId)
}

if expected := 32; payload.Role.IncludedPermissions != nil && len(payload.Role.IncludedPermissions) != expected {
if expected := 31; payload.Role.IncludedPermissions != nil && len(payload.Role.IncludedPermissions) != expected {
t.Errorf("expected %d permissions, got %d", expected, len(payload.Role.IncludedPermissions))
}

Expand Down
1 change: 0 additions & 1 deletion internal/reconcilers/google/gcp/role.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ func (r *googleGcpReconciler) createTeamRole(ctx context.Context, projectId stri
"cloudsql.users.list",
"cloudsql.users.update",
"resourcemanager.projects.get",
"resourcemanager.projects.list",
"resourcemanager.projects.getIamPolicy",
"storage.buckets.get",
"storage.buckets.getIamPolicy",
Expand Down

0 comments on commit 1d55260

Please sign in to comment.