More features added: star, mark as read, bug fixes (including PR#131) #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonj
reviewed
Oct 15, 2018
simonj
reviewed
Oct 15, 2018
|
Have you runned something like reformat code? seems like all the code has been touched but not all has changed |
nahid
requested changes
Oct 16, 2018
database/migrations/2015_10_05_110622_create_conversations_table.php
Outdated
Show resolved
Hide resolved
nahid
requested changes
Oct 16, 2018
database/migrations/2015_10_05_110622_create_conversation_tag_table.php
Outdated
Show resolved
Hide resolved
|
@damms005 can you perform the changes requested, please? We would like to merge the suggested changes |
cfpinto
reviewed
Oct 31, 2018
|
@cfpinto I'd like to re-PR these changes. Kindly address the issues in the comments |
damms005
force-pushed
the
feature_tag_conversation
branch
from
1ce63f5 to
51731fd
Compare
damms005
changed the title
hoanghungict
reviewed
Jun 5, 2019
| @@ -18,6 +21,39 @@ | |||
| */ | |||
| class Adapter extends Service | |||
| { | |||
| <<<<<<< HEAD | |||
|
This was closed in favor of PR #145 |
damms005
added a commit
to damms005/talk
that referenced
this pull request
Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR title says it all. More details in the commit change log :)