Added charMap property in Digit. Added Story for additional character… #3
Conversation
… in charMap. Exported default character to variable. Added Story for illegal character. Added .gitignore
|
I'm loaded on work right now, but I'll review this PR soon! |
| @@ -1,6 +1,7 @@ | |||
| import { Meta, StoryObj } from "@storybook/react"; | |||
|
|
|||
| import { Digit } from "../components/Digit"; | |||
| import CharToDigit from "../utils/charToDigit"; | |||
There was a problem hiding this comment.
Here, the import should be chatToDigit
There was a problem hiding this comment.
I don't quite get it? Do I have a typo? Do you😅?
There was a problem hiding this comment.
Yes, it's a typo. Since utils/charToDigit.ts exports charToDigit by default, you can rename it when you import it, that's why this code works anyways. But it should be charToDigit since it is the array that you want and not the type. Don't worry, I'll merge the PR and then fix it.
src/utils/charToDigit.ts
Outdated
There was a problem hiding this comment.
I like the idea of giving this type a name, but I would like it to be a type and not an interface (for consistency). On top of that, let's change the name to CharMap (without an I at the start). Also, if you think it's a good idea, change charToDigit to defaultCharMap.
through-space
force-pushed
the
char-map-param
branch
from
c675120 to
f1663e1
Compare
… in charMap. Exported default character to variable. Added Story for illegal character. Added .gitignore