Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages #1

Merged
merged 8 commits into from
Jul 3, 2024
Merged

Conversation

theaswanson
Copy link
Contributor

This PR updates the packages to their latest versions. Most notably, TypeScript gets upgraded from v4 to v5, and Storybook goes from v6 to v8.

I was having issues building this project and running Storybook on Windows, and these updates appear to fix that.

If there's anything you'd like me to change, please let me know!

Copy link
Owner

@nachovigilante nachovigilante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of updating the packages. Revert the changes on formatting and I'll accept it. Don't worry about the /dist directory, I'll remove it from the repo later. Thanks for investing time on this!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change the default formatting rules

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left /dist folder by accident, it shouldn't be included in the repository. I'm sorry! :(

@theaswanson
Copy link
Contributor Author

@nachovigilante I've reverted the formatting and removed the changes to dist. Let me know what you think!

Copy link
Owner

@nachovigilante nachovigilante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time!

@nachovigilante nachovigilante merged commit eb36629 into nachovigilante:main Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants