-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packages #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of updating the packages. Revert the changes on formatting and I'll accept it. Don't worry about the /dist
directory, I'll remove it from the repo later. Thanks for investing time on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't change the default formatting rules
dist/cjs/components/Digit.d.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left /dist
folder by accident, it shouldn't be included in the repository. I'm sorry! :(
This reverts commit 5844a50.
@nachovigilante I've reverted the formatting and removed the changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time!
This PR updates the packages to their latest versions. Most notably, TypeScript gets upgraded from v4 to v5, and Storybook goes from v6 to v8.
I was having issues building this project and running Storybook on Windows, and these updates appear to fix that.
If there's anything you'd like me to change, please let me know!