Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to pyOpenSSL for validating certificate chain #566

Closed
nabla-c0d3 opened this issue May 14, 2022 · 1 comment
Closed

Switch to pyOpenSSL for validating certificate chain #566

nabla-c0d3 opened this issue May 14, 2022 · 1 comment

Comments

@nabla-c0d3
Copy link
Owner

To further address the memory leak affecting the certificate validation logic (#560), we should switch from nassl's to pyOpenSSL's API (https://www.pyopenssl.org/en/stable/api/crypto.html#x509storecontext-objects).

pyOpenSSL is already an implicit dependency of SSLyze since it's a dependency of cryptography.
@nabla-c0d3 nabla-c0d3 mentioned this issue Nov 6, 2022
Open
nabla-c0d3 added a commit that referenced this issue Nov 6, 2022
@nabla-c0d3
[#566] Switch to pyOpenSSL for validating certificate chain
95dcccf
nabla-c0d3 added a commit that referenced this issue Nov 6, 2022
@nabla-c0d3
[#566] Switch to pyOpenSSL for validating certificate chain
876e2a1
nabla-c0d3 added a commit that referenced this issue Nov 6, 2022
@nabla-c0d3
[#566] Switch to pyOpenSSL for validating certificate chain
29e9fd2
@nabla-c0d3 nabla-c0d3 moved this to Done in SSLyze 5.1.0 Nov 6, 2022
nabla-c0d3 added a commit that referenced this issue Nov 6, 2022
@nabla-c0d3
[#566] Switch to pyOpenSSL for validating certificate chain
bf8c53e
nabla-c0d3 added a commit that referenced this issue Nov 6, 2022
@nabla-c0d3
[#566] Switch to pyOpenSSL for validating certificate chain
11f135d
nabla-c0d3 added a commit that referenced this issue Nov 6, 2022
@nabla-c0d3
[#566] Switch to pyOpenSSL for validating certificate chain
fafb4da
@nabla-c0d3
Copy link
Owner Author

Fix released as part of v5.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
SSLyze 5.1.0
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nabla-c0d3