Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FLAC__stream_encoder_set_limit_min_bitrate to config.rs #6

Closed
wants to merge 1 commit into from
Closed

Conversation

dheijl
Copy link
Contributor

@dheijl dheijl commented Nov 5, 2024

This adds FLAC__stream_encoder_set_limit_min_bitrate (and the corresponding set_limit_min_bitrate(), but only to the libflac feature, as flac-sys seems unmaintained now and not updated for ages. It was introduced in FLAC 1.4.0 I think.

This allows one to limit the compression of digital silence to prevent streaming connection loss.

See xiph/flac#264.

I'm sorry about the reformatting that VSCode has done to config.rs, it's not intentional.

add FLAC__stream_encoder_set_limit_min_bitrate

This allows one to limit the compression of digital silence to prevent streaming connection loss.

See see xiph/flac#264.
@nabijaczleweli nabijaczleweli added the enhancement New feature or request label Nov 5, 2024
@nabijaczleweli
Copy link
Owner

nabijaczleweli commented Nov 5, 2024

I'd much rather an unformatted diff than one raked with Some reformatter, but whatever. Applied as 4acf5d0 (changed the interface to take a bool and cast it appropriately). Warning added about flac-sys too.

@nabijaczleweli
Copy link
Owner

Released in v0.5.0, thanks

@dheijl
Copy link
Contributor Author

dheijl commented Nov 5, 2024

Sorry again about the formatting and thanks for fixing and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants