fix(editor): Optionally share credentials used by the workflow when moving the workflow between projects #12524
Conversation
n8n-assistant
bot
added
n8n team
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
ADO-3163-folders-navigation
|
| Run status |
|
| Run duration | 04m 37s |
| Commit |
|
| Committer | Milorad Filipovic |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
437
|
| View all changes introduced in this branch ↗︎ | |
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
…re-credentials' of github.com:n8n-io/n8n into pay-1745-update-moved-workflow-to-include-option-to-share-credentials
…ed-workflow-to-include-option-to-share-credentials # Conflicts: # packages/@n8n/api-types/src/dto/index.ts
…ed-workflow-to-include-option-to-share-credentials
…ed-workflow-to-include-option-to-share-credentials # Conflicts: # packages/editor-ui/src/components/Projects/ProjectMoveResourceModal.test.ts
…ed-workflow-to-include-option-to-share-credentials
…ed-workflow-to-include-option-to-share-credentials
|
✅ All Cypress E2E specs passed |
|
✅ All Cypress E2E specs passed |
| @@ -402,11 +417,10 @@ export class WorkflowsController { | |||
| ); | |||
| } | |||
|
|
|||
| @Licensed('feat:sharing') | |||
There was a problem hiding this comment.
@despairblue it fails because of this change
Isn't it doing the same?
If I roll it back it works
There was a problem hiding this comment.
This was correct. I don't know why the tests passed at all. The tests are in the none-ee file. The requests should rightfully be 404s not 200s.
The tests should be in: packages/cli/test/integration/workflows/workflows.controller.ee.test.ts, or actually even in the service test file, since they test service logic, not controller logic.
|
✅ All Cypress E2E specs passed |
|
✅ All Cypress E2E specs passed |
|
✅ All Cypress E2E specs passed |
cstuncsik
deleted the
pay-1745-update-moved-workflow-to-include-option-to-share-credentials
branch
Summary
If a user moves a workflow to a different project, they can optionally choose to share the credentials used by the workflow (if any) with the destination project.
Only the credentials the user has access to will be shared.
Related Linear tickets, Github issues, and Community forum posts
PAY-1745
Review / Merge checklist
release/backport