Extract all VR4300 interfaces to interface.h #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could anyone please review that? |
|
It does have a merge conflict with an earlier commit though... |
|
Merged via web interface. Please let me check the code still works... |
|
Reopened as #125 - new interfaces for profiling were required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this patch we encapsulate VR4300 internals from other devices, and now they have to include only
vr4300/interface.hheader. It makes possible to use alternative models of VR4300 if they implement the same interfaces. But there is a drawback: we allocatevr4300structure on heap now.