Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add additional todos in the "change checklist" #3180

Merged
merged 6 commits into from
Feb 21, 2025
Merged

chore: add additional todos in the "change checklist" #3180

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4852b97
chore: add additional todos in the "change checklist"
Feb 11, 2025
646fd83
chore: tweak wordage
Feb 11, 2025
e6debb6
chore: add additional comment
Feb 11, 2025
9bd2b83
chore: adjust language under "Document all breaking changes" section
Feb 12, 2025
532d8cc
chore: adjust wording
Feb 12, 2025
15419ee
add links to repos
Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,15 @@
<!-- Any notes, remarks or open questions you have to make about the PR. -->

## Change checklist

<!-- Remove any that are not relevant. -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're daring to add explicit instructions! I had given up on this :D

- [ ] Self-review.
- [ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant.
- [ ] Tests if relevant.
- [ ] All breaking changes documented.
- [ ] List all breaking changes in the above "Breaking Changes" section.
- [ ] Open an issue or PR on any number0 repos that are affected by this breaking change. Give guidance on how the updates should be handled or do the actual updates themselves. The major ones are:
- [ ] [`quic-rpc`](https://github.com/n0-computer/quic-rpc)
- [ ] [`iroh-gossip`](https://github.com/n0-computer/iroh-gossip)
- [ ] [`iroh-blobs`](https://github.com/n0-computer/iroh-blobs)
- [ ] [`dumbpipe`](https://github.com/n0-computer/dumbpipe)
- [ ] [`sendme`](https://github.com/n0-computer/sendme)
Loading