refactor: use OS-specific config & data dirs, default iroh-store dir #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b5
force-pushed
the
feat/dirs_dev
branch
3 times, most recently
from
1616340 to
2df6113
Compare
b5
commented
Sep 1, 2022
b5
commented
Sep 2, 2022
Comment on lines
+23
to
+26
| match arg_path { | ||
| Some(p) => Ok(p), | ||
| None => iroh_data_path("store"), | ||
| } |
There was a problem hiding this comment.
I'm unclear on weather or not there's a more succinct way to express this
There was a problem hiding this comment.
I think arg_path.map_or(iroh_data_path("store"), |v| Ok(v)) is equivalent - but not easier to read!
There was a problem hiding this comment.
oooh I hadn't found map_or. Thanks for the tip @fabricedesre! I agree with you that the match is easier to read, and will leave it as is unless I'm overruled by dig 😄
There was a problem hiding this comment.
seems fine and readable
Arqu
previously approved these changes
Sep 7, 2022
switch to using https://dirs.dev standard application directories instead of $HOME/.iroh iroh-store now uses a default directory for datastore data instead of explicitly requiring a store path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switch to using https://dirs.dev/ standard application directories instead of $HOME/.iroh
iroh-store now uses a default directory for writing rocksDB files instead of explicitly requiring a store path. Defaults to
/iroh/storewithin the OS application data directory.closes n0-computer/beetle#231