chore(iroh-bytes): use latest bao tree #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rklaehn
commented
Mar 20, 2024
| @@ -183,12 +183,6 @@ impl SizeInfo { | |||
|
|
|||
| /// Persist into a file where each chunk has its own slot. | |||
| fn persist(&self, mut target: impl WriteAt) -> io::Result<()> { | |||
| if self.offset & ((IROH_BLOCK_SIZE.bytes() as u64) - 1) != 0 { | |||
| return Err(io::Error::new( | |||
There was a problem hiding this comment.
This test does not really make sense. It is perfectly fine to get sub chunk group data, e.g. if you request 1 chunk.
dignifiedquire
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the latest version of bao-tree that has some bugfixes and a new validate fn.
Notes & open questions
Due to the bugfix this means that it is no longer compatible with the previous version of iroh-bytes in some rare circumstances involving resume.
We would therefore have to increase the iroh-bytes APLN before the next release.
Change checklist