feat: usage metrics reporting #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arqu
added
feat
flub
reviewed
Dec 5, 2023
iroh-net/src/derp/server.rs
Outdated
| 1, | ||
| None, // TODO(arqu): attribute to user id; possibly with the re-introduction of request tokens or other auth | ||
| Some(key.to_string()), | ||
| )).await.unwrap_or_else(|e| tracing::warn!("error reporting usage stats: {:?}", e)); |
There was a problem hiding this comment.
For metrics-like APIs it might be better to make the functions infallible and handle the error reporting in the function itself. I assume this will end up being strewn around the code in many places?
flub
approved these changes
Dec 5, 2023
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description Simple extension to the metrics collector to have a dedicated usage reporting flow. ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [ ] Self-review. - [ ] Documentation updates if relevant. - [ ] Tests if relevant. --------- Co-authored-by: Floris Bruynooghe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple extension to the metrics collector to have a dedicated usage reporting flow.
Notes & open questions
Change checklist