Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: doc export exports the latest entry at a given key #1629

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

ramfox
Copy link
Contributor

@ramfox ramfox commented Oct 12, 2023

Description

We currently only export via the latest key & the author id, but in the CLI and console, we don't currently have a way of viewing other authors.

This needs to be fixed asap for demo purposes, and we should have a longer discussion about how we expose the other peers' author ids to the CLI and console: #1628

Change checklist

  • Self-review.
  • Documentation updates if relevant.

the only author the CLI/console can know about right now is yourself, until we have a way of viewing other authors, we should default to looking for the latest key
@ramfox ramfox added the fix Fixes a bug label Oct 12, 2023
@ramfox ramfox requested a review from b5 October 12, 2023 15:52
@ramfox ramfox self-assigned this Oct 12, 2023
Copy link
Contributor

@divagant-martian divagant-martian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried it out, it works. Checked the code, lgtm!

@divagant-martian divagant-martian added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit b815576 Oct 12, 2023
@b5 b5 added this to the v0.7.1 milestone Oct 12, 2023
@ramfox ramfox deleted the export_fix branch November 1, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants