feat: enable metrics server on sync REPL #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arqu
changed the title
Arqu
changed the title
Arqu
force-pushed
the
arqu/sync_metrics_server
branch
from
7396864 to
283f337
Compare
Arqu
added
metrics
iroh/examples/sync.rs
Outdated
| @@ -32,6 +30,7 @@ use iroh_net::{ | |||
| use iroh_sync::sync::{Author, Namespace, SignedEntry}; | |||
| use once_cell::sync::OnceCell; | |||
| use serde::{Deserialize, Serialize}; | |||
| use std::{fmt, net::SocketAddr, path::PathBuf, str::FromStr, sync::Arc}; | |||
There was a problem hiding this comment.
please keep std imports seperated out
dignifiedquire
approved these changes
Jul 27, 2023
Arqu
force-pushed
the
arqu/sync_metrics_server
branch
from
283f337 to
49112e0
Compare
Frando
pushed a commit
that referenced
this pull request
Jul 28, 2023
Frando
pushed a commit
that referenced
this pull request
Jul 28, 2023
Frando
pushed a commit
that referenced
this pull request
Jul 28, 2023
Frando
pushed a commit
that referenced
this pull request
Aug 7, 2023
Frando
pushed a commit
that referenced
this pull request
Aug 10, 2023
Frando
pushed a commit
that referenced
this pull request
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a flag to start serving metrics on an endpoint in OpenMetrics form, makes life easier to plug it into other tooling.
Notes & open questions
Change checklist