fix(iroh): Properly shut down the store on control-c #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rklaehn
force-pushed
the
better-shutdown
branch
from
2b089ff to
ab9226b
Compare
rklaehn
commented
Mar 20, 2024
| @@ -1153,12 +1155,21 @@ impl StoreInner { | |||
| fn temp_file_name(&self) -> PathBuf { | |||
| self.path_options.temp_file_name() | |||
| } | |||
|
|
|||
| async fn shutdown(&self) { | |||
There was a problem hiding this comment.
God how I hate all this boilerplate. But no macros please. At some point I will write an actor framework to solve this...
without this, the (flaky) cli_provide_persistence test fails, because control-c interrupts the store before the write transaction is committed.
rklaehn
force-pushed
the
better-shutdown
branch
from
ab9226b to
4ca20b0
Compare
## Description Use the latest version of bao-tree that has some bugfixes and a new validate fn. ## Notes & open questions Due to the bugfix this means that it is no longer compatible with the previous version of iroh-bytes in some rare circumstances involving resume. We would therefore have to increase the iroh-bytes APLN before the next release. ## Change checklist - [ ] Self-review. - [ ] Documentation updates if relevant. - [ ] Tests if relevant.
dignifiedquire
approved these changes
Mar 20, 2024
# Conflicts: # iroh-bytes/src/store/bao_file.rs
rklaehn
force-pushed
the
better-shutdown
branch
from
91a3c0a to
5f10ba3
Compare
matheus23
pushed a commit
that referenced
this pull request
Nov 14, 2024
## Description
fix(iroh): Properly shut down the store on control-c
without this, the (flaky) cli_provide_persistence test fails, because
control-c interrupts the store before the write transaction is
committed.
## Notes & open questions
Should we change shutdown in node to be async, and remove the impl
Future for Node?
## Change checklist
- [x] Self-review.
- [x] Documentation updates if relevant.
- [x] Tests if relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix(iroh): Properly shut down the store on control-c
without this, the (flaky) cli_provide_persistence test fails, because
control-c interrupts the store before the write transaction is committed.
Notes & open questions
Should we change shutdown in node to be async, and remove the impl Future for Node?
Change checklist