Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unexpected rpc-port behaviour when iroh daemon goes away and comes back #1837

Open
divagant-martian opened this issue Nov 24, 2023 · 2 comments
Open

unexpected rpc-port behaviour when iroh daemon goes away and comes back #1837

divagant-martian opened this issue Nov 24, 2023 · 2 comments
Labels
_c-iroh-cli

Comments

@divagant-martian
Copy link
Contributor

divagant-martian commented Nov 24, 2023 •
edited
Loading

Running on 1dfb7ac

Reproduction steps:

  1. start an iroh node (this will use the default port)
  2. start a second iroh node pointing to a different iroh data dir (this will use a random port and create a file with it)
  3. start a console pointing to the custom data dir of the second iroh node
  4. kill the second node
  5. run the second node again (providing the same data dir as before) this will use the default port and the console will not be able to talk to it
@github-project-automation github-project-automation bot moved this to 📋 Backlog in iroh Nov 24, 2023
@divagant-martian divagant-martian mentioned this issue Nov 24, 2023
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 25, 2023
@divagant-martian
refactor(iroh): remove rpc port option (#1842)
d1fcfca 
## Description

Removes the rpc-port option from the start args, effectively removing
the whole struct

## Notes & open questions

keeping this would be the only work around to #1837. Not having this I
think is better and forces us to actually solve this issue

## Change checklist

- [x] Self-review.
- [ ] Documentation updates if relevant.
- [ ] Tests if relevant.
@divagant-martian
Copy link
Contributor Author

for the sake of keeping this alive, just tested on current main (a42c1b2) and still can reproduce

@divagant-martian
Copy link
Contributor Author

still happening on current main (2d04306)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
_c-iroh-cli
Projects
iroh
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@divagant-martian