Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: easy way to set RUST_LOG #1716

Closed
Arqu opened this issue Oct 24, 2023 · 2 comments · Fixed by #1737
Closed

CI: easy way to set RUST_LOG #1716

Arqu opened this issue Oct 24, 2023 · 2 comments · Fixed by #1737
Assignees
@Arqu
Labels
ci continous integration

Comments

@Arqu
Copy link
Collaborator

Arqu commented Oct 24, 2023

No description provided.

@Arqu Arqu self-assigned this Oct 24, 2023
@Arqu Arqu added this to iroh Oct 24, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in iroh Oct 24, 2023
@flub
Copy link
Contributor

flub commented Oct 24, 2023

What do you have in mind for this? Is this complementary to iroh_test::logging, replacement?

@dignifiedquire
Copy link
Contributor

The goal is to have a way to rerun a specific test with logging enabled on CI, no matter if it fails or not

@Arqu Arqu mentioned this issue Oct 26, 2023
Merged
3 tasks
@dignifiedquire dignifiedquire added the ci continous integration label Oct 26, 2023
@Arqu Arqu moved this from 📋 Backlog to 🏗 In progress in iroh Oct 27, 2023
dignifiedquire added a commit that referenced this issue Oct 30, 2023
@Arqu @dignifiedquire
feat(ci): CI improvements (#1737)
10f5982 
## Description

😢 this does add ~3 min to the existing 7min of linux runs, but at least
it properly checks all crates now.

Closes #1716
You can now click on re run job and in the bottom of the prompt you can
check `enable debug logging` to run with `RUST_LOG=DEBUG` & `netsim
--debug` for the appropriate tests to get full logging output.
<img width="640" alt="Screenshot 2023-10-26 at 12 57 52"
src="https://github.com/n0-computer/iroh/assets/1760977/3920ee51-e26e-4557-b9f7-ef9f28bd8f25">
<img width="640" alt="Screenshot 2023-10-26 at 12 58 05"
src="https://github.com/n0-computer/iroh/assets/1760977/743fc8d1-2cb1-4d9e-9a0e-6dbac4aa27f9">

Closes #1717
Linker changes are still up for debate

Closes #1423
We need to maintain the crates list, but shouldn't be too hard. Managed
to pull it out into a single var.

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- [ ] Documentation updates if relevant.
- [ ] Tests if relevant.

---------

Co-authored-by: Friedel Ziegelmayer <[email protected]>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Oct 30, 2023
divagant-martian pushed a commit to divagant-martian/iroh that referenced this issue Oct 31, 2023
@Arqu @dignifiedquire @divagant-martian
feat(ci): CI improvements (n0-computer#1737)
91145b3 
## Description

😢 this does add ~3 min to the existing 7min of linux runs, but at least
it properly checks all crates now.

Closes n0-computer#1716
You can now click on re run job and in the bottom of the prompt you can
check `enable debug logging` to run with `RUST_LOG=DEBUG` & `netsim
--debug` for the appropriate tests to get full logging output.
<img width="640" alt="Screenshot 2023-10-26 at 12 57 52"
src="https://github.com/n0-computer/iroh/assets/1760977/3920ee51-e26e-4557-b9f7-ef9f28bd8f25">
<img width="640" alt="Screenshot 2023-10-26 at 12 58 05"
src="https://github.com/n0-computer/iroh/assets/1760977/743fc8d1-2cb1-4d9e-9a0e-6dbac4aa27f9">

Closes n0-computer#1717
Linker changes are still up for debate

Closes n0-computer#1423
We need to maintain the crates list, but shouldn't be too hard. Managed
to pull it out into a single var.

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- [ ] Documentation updates if relevant.
- [ ] Tests if relevant.

---------

Co-authored-by: Friedel Ziegelmayer <[email protected]>
rklaehn pushed a commit to n0-computer/iroh-blobs that referenced this issue Oct 22, 2024
@Arqu @dignifiedquire
feat(ci): CI improvements (#1737)
77d258f 
## Description

😢 this does add ~3 min to the existing 7min of linux runs, but at least
it properly checks all crates now.

Closes n0-computer/iroh#1716
You can now click on re run job and in the bottom of the prompt you can
check `enable debug logging` to run with `RUST_LOG=DEBUG` & `netsim
--debug` for the appropriate tests to get full logging output.
<img width="640" alt="Screenshot 2023-10-26 at 12 57 52"
src="https://github.com/n0-computer/iroh/assets/1760977/3920ee51-e26e-4557-b9f7-ef9f28bd8f25">
<img width="640" alt="Screenshot 2023-10-26 at 12 58 05"
src="https://github.com/n0-computer/iroh/assets/1760977/743fc8d1-2cb1-4d9e-9a0e-6dbac4aa27f9">

Closes n0-computer/iroh#1717
Linker changes are still up for debate

Closes n0-computer/iroh#1423
We need to maintain the crates list, but shouldn't be too hard. Managed
to pull it out into a single var.

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- [ ] Documentation updates if relevant.
- [ ] Tests if relevant.

---------

Co-authored-by: Friedel Ziegelmayer <[email protected]>
matheus23 pushed a commit to n0-computer/iroh-doctor that referenced this issue Oct 22, 2024
@Arqu @dignifiedquire
feat(ci): CI improvements (#1737)
25c47ca 
## Description

😢 this does add ~3 min to the existing 7min of linux runs, but at least
it properly checks all crates now.

Closes n0-computer/iroh#1716
You can now click on re run job and in the bottom of the prompt you can
check `enable debug logging` to run with `RUST_LOG=DEBUG` & `netsim
--debug` for the appropriate tests to get full logging output.
<img width="640" alt="Screenshot 2023-10-26 at 12 57 52"
src="https://github.com/n0-computer/iroh/assets/1760977/3920ee51-e26e-4557-b9f7-ef9f28bd8f25">
<img width="640" alt="Screenshot 2023-10-26 at 12 58 05"
src="https://github.com/n0-computer/iroh/assets/1760977/743fc8d1-2cb1-4d9e-9a0e-6dbac4aa27f9">

Closes n0-computer/iroh#1717
Linker changes are still up for debate

Closes n0-computer/iroh#1423
We need to maintain the crates list, but shouldn't be too hard. Managed
to pull it out into a single var.

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- [ ] Documentation updates if relevant.
- [ ] Tests if relevant.

---------

Co-authored-by: Friedel Ziegelmayer <[email protected]>
matheus23 pushed a commit that referenced this issue Nov 14, 2024
@Arqu @dignifiedquire
feat(ci): CI improvements (#1737)
aef055d 
## Description

😢 this does add ~3 min to the existing 7min of linux runs, but at least
it properly checks all crates now.

Closes #1716
You can now click on re run job and in the bottom of the prompt you can
check `enable debug logging` to run with `RUST_LOG=DEBUG` & `netsim
--debug` for the appropriate tests to get full logging output.
<img width="640" alt="Screenshot 2023-10-26 at 12 57 52"
src="https://github.com/n0-computer/iroh/assets/1760977/3920ee51-e26e-4557-b9f7-ef9f28bd8f25">
<img width="640" alt="Screenshot 2023-10-26 at 12 58 05"
src="https://github.com/n0-computer/iroh/assets/1760977/743fc8d1-2cb1-4d9e-9a0e-6dbac4aa27f9">

Closes #1717
Linker changes are still up for debate

Closes #1423
We need to maintain the crates list, but shouldn't be too hard. Managed
to pull it out into a single var.

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- [ ] Documentation updates if relevant.
- [ ] Tests if relevant.

---------

Co-authored-by: Friedel Ziegelmayer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arqu Arqu

Labels
ci continous integration
Projects
iroh
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ci): CI improvements n0-computer/iroh
3 participants
@flub @dignifiedquire @Arqu