Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: node::Builder::disable_derp is broken #1558

Closed
Frando opened this issue Oct 2, 2023 · 0 comments · Fixed by #1560
Closed

Bug: node::Builder::disable_derp is broken #1558

Frando opened this issue Oct 2, 2023 · 0 comments · Fixed by #1560
Assignees
@Frando
Labels
bug Something isn't working

Comments

@Frando
Copy link
Member

Frando commented Oct 2, 2023

.. as in, has no effect. We moved the default in MagicEndpoint to be the default derp map (and not no derp). However, we never call MagicEndpointBuilder::disable_derp(), even if you call node::Builder::disable_derp. This needs to be fixed.
@github-project-automation github-project-automation bot moved this to 📋 Backlog in iroh Oct 2, 2023
@Frando Frando mentioned this issue Oct 2, 2023
Merged
3 tasks
@dignifiedquire dignifiedquire added the bug Something isn't working label Oct 2, 2023
@dignifiedquire dignifiedquire moved this from 📋 Backlog to 👀 In review in iroh Oct 2, 2023
github-merge-queue bot pushed a commit that referenced this issue Oct 2, 2023
@Frando
fix: actually allow to disable DERP (#1560)
cf9abc0 
## Description

`node::Builder::disable_derp` is broken. We do not call
`MagicEndpointBuilder::disable_derp` for that, and at some point we
changed the magic endpoint to default to the default, n0-supplied derp
servers.

This fixes this through a `DerpMode` enum that is much more explicit I
think.

Fixes #1558 

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- [x] Documentation updates if relevant.
- [x] Tests if relevant.
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in iroh Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Frando Frando

Labels
bug Something isn't working
Projects
iroh
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: actually allow to disable DERP n0-computer/iroh
2 participants
@Frando @dignifiedquire