Skip to content

Commit

Permalink
refactor(iroh-net): bump netcheck DNS timeout to 3s (#2077)
Browse files Browse the repository at this point in the history
## Description

We've seen 1s not being long enough.  The probes time out after 3s, so
let's match that timeout and see how that goes.

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- [x] Documentation updates if relevant.
- [x] Tests if relevant.
  • Loading branch information
flub authored Mar 13, 2024
1 parent 3747a09 commit 24b38c8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion iroh-net/src/netcheck/reportgen.rs
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const CAPTIVE_PORTAL_TIMEOUT: Duration = Duration::from_secs(2);

const ENOUGH_NODES: usize = 3;

const DNS_TIMEOUT: Duration = Duration::from_secs(1);
const DNS_TIMEOUT: Duration = Duration::from_secs(3);

/// Holds the state for a single invocation of [`netcheck::Client::get_report`].
///
Expand Down
4 changes: 2 additions & 2 deletions iroh-net/src/netcheck/reportgen/hairpin.rs
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ struct Actor {
impl Actor {
async fn run(self) {
match self.run_inner().await {
Ok(_) => debug!("hairpin actor finished successfully"),
Ok(_) => trace!("hairpin actor finished successfully"),
Err(err) => error!("Hairpin actor failed: {err:#}"),
}
}
Expand Down Expand Up @@ -137,7 +137,7 @@ impl Actor {
Ok(Err(_)) => bail!("netcheck actor dropped stun response channel"),
Err(_) => false, // Elapsed
};
tracing::debug!(
debug!(
"hairpinning done in {:?}, res: {:?}",
now.elapsed(),
hairpinning_works
Expand Down

0 comments on commit 24b38c8

Please sign in to comment.