feat: use file extensions from collection names for MIME guessing #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to serve a website (HTML and CSS) from an iroh collection with the
iroh-gateway
example. It works, but CSS is not applied to the page because the gateway serves CSS files withtext/plain
, which makes the browser ignore it.The MIME guesser currently only uses the blob data to guess the mime type (via mime_classifier. This is insufficient in many cases (e.g. all text files will be
text/plain
).This PR changes this so that for blobs served through collections, the extension of the filename from the collection metadata is used to guess the MIME type. If the file has no or an unknown extension, it falls back to the
mime_classifier
.With this change, we can serve websites. At least basic static sites.