[#1] New Tidy compatibility update #2
Conversation
Removed Tidy wire-up from the standard render path. Just a recommendation: changed render(true) to render(false) to prevent unexpected behaviors when the user is updated. There are a variety of reasons why the user will update in the current version of Foundry dnd5e.
| @@ -139,6 +204,6 @@ function removeInspiration(user, _sheet) { | |||
|
|
|||
| function updateSheetForInspo(user) { | |||
| if (user?.character.sheet.rendered) { | |||
| user.character.sheet.render(true); | |||
| user.character.sheet.render(false); | |||
There was a problem hiding this comment.
@mysurvive this is mostly just a recommendation.
render(true) can have some surprising effects when it fires off for each user change.
Tidy and the new Default Sheets can frequently have user changes that do not relate to this module which can be triggered from actions within the sheet, such as changing the sort on various tabs.
I tested it and noted that the legacy sheet and Tidy were refreshing successfully with a render(false).
src/module/so-inspired.js
Outdated
| @@ -23,6 +23,75 @@ Hooks.on("updateUser", (user) => { | |||
| updateSheetForInspo(user); | |||
| //updatePlayerListInspo(); | |||
| }); | |||
|
|
|||
| Hooks.on("tidy5e-sheet.renderActorSheet", (app, element, data) => { | |||
There was a problem hiding this comment.
Because I'm running things in svelte, I have to post up my own lifecycle hook.
| inspirationArea.hide(); | ||
|
|
||
| let currentInspiration; | ||
| const actorOwner = game.users.find( |
There was a problem hiding this comment.
For this PR, I just copied a lot of the functionality from the main logic. Please feel free to extract the common behaviors into functions if that works better for you.
| > | ||
| <i | ||
| class="fa-solid fa-plus" | ||
| style="color: var(--t5e-primary-font-color)" |
There was a problem hiding this comment.
This CSS variable reference makes So Inspired! work with Tidy's light and dark modes 💪💅
|
You're fast. I was trying to push the linting issue fix and was wondering why my branch was behind :) |
|
Oh yeah, sorry about that! I happened to see it while I was at a computer. |
|
Absolutely, glad people are enjoying the module. My DM asked if I could make a SWADE/PF2e style inspiration module for our game - didn't expect anyone else beside my DM to use it :) You can send me a message on Discord if you need anything else (or on here is fine, of course) - mysurvive Resolves #1 |
#1