User: add unit test for GetShortName - do not convert to upper case

User.go

@@ -137,7 +137,7 @@ func (u User) GetShortName() string {
 	if len(supn) != 2 {
 		return u.UserPrincipalName
 	}
-	return strings.ToUpper(supn[0])
+	return supn[0]
 }
 
 // GetFullName returns the full name in that format: <firstname> <lastname>

User_test.go

@@ -194,6 +194,19 @@ func TestUser_UpdateUser(t *testing.T) {
 	}
 }
 
+func TestUser_GetShortName(t *testing.T) {
+	// test a normal case
+	testuser := User{UserPrincipalName: "[email protected]"}
+	if testuser.GetShortName() != "dumpty" {
+		t.Errorf("user.GetShortName() should return \"dumpty\", but returns: %v", testuser.GetShortName())
+	}
+	// test a case that actually should never happen... but we all know murphy
+	testuser = User{UserPrincipalName: "alice"}
+	if testuser.GetShortName() != "alice" {
+		t.Errorf("user.GetShortName() should return \"alice\", but returns: %v", testuser.GetShortName())
+	}
+}
+
 func TestUser_GetFullName(t *testing.T) {
 	testuser := User{GivenName: "Bob", Surname: "Rabbit"}
 	wanted := fmt.Sprintf("%v %v", testuser.GivenName, testuser.Surname)