Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow delivery date to be used with DHLForYou #511

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GravendeelJochem
Copy link
Contributor

@GravendeelJochem GravendeelJochem commented Nov 26, 2024

Add support for setting a delivery date when shipping packages via DHLForYou.
INT-867

@GravendeelJochem GravendeelJochem requested a review from a team as a code owner November 26, 2024 08:44
@myparcel-bot myparcel-bot bot force-pushed the feat-allow-delivery-date-dhlforyou branch from 9ddb556 to 121a4ac Compare December 6, 2024 11:21
@myparcel-bot myparcel-bot bot force-pushed the feat-allow-delivery-date-dhlforyou branch from 121a4ac to b30b10f Compare December 20, 2024 11:07
@FreekVR
Copy link
Contributor

FreekVR commented Dec 20, 2024

@GravendeelJochem kun je deze nog wel even koppelen aan het bijbehorende Jira ticket via regel in je commit / PR desc?

@myparcel-bot myparcel-bot bot force-pushed the feat-allow-delivery-date-dhlforyou branch from b30b10f to f6850c9 Compare January 2, 2025 14:48
@myparcel-bot myparcel-bot bot force-pushed the feat-allow-delivery-date-dhlforyou branch from f6850c9 to 37dbe4c Compare January 15, 2025 12:52
@myparcel-bot myparcel-bot bot force-pushed the feat-allow-delivery-date-dhlforyou branch from 37dbe4c to 589909b Compare February 3, 2025 15:10
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.21%. Comparing base (20b74e6) to head (589909b).
Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
src/Model/Consignment/DHLForYouConsignment.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #511      +/-   ##
============================================
- Coverage     59.04%   58.21%   -0.84%     
- Complexity     1804     1904     +100     
============================================
  Files           110      112       +2     
  Lines          4283     4492     +209     
============================================
+ Hits           2529     2615      +86     
- Misses         1754     1877     +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@myparcel-bot myparcel-bot bot force-pushed the feat-allow-delivery-date-dhlforyou branch from 589909b to abb58a5 Compare February 18, 2025 13:31
@myparcel-bot myparcel-bot bot force-pushed the feat-allow-delivery-date-dhlforyou branch from abb58a5 to 9fa62af Compare March 5, 2025 09:29
@myparcel-bot myparcel-bot bot force-pushed the feat-allow-delivery-date-dhlforyou branch from 9fa62af to 435ef8c Compare March 5, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants