Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure there is no remnant runner config before configuring #403

Merged
merged 2 commits into from
Oct 6, 2024
Merged

Make sure there is no remnant runner config before configuring #403

merged 2 commits into from
Oct 6, 2024

Conversation

bodograumann
Copy link
Contributor

Closes #402

myoung34
myoung34 requested changes Oct 5, 2024
View reviewed changes
Copy link
Owner

@myoung34 myoung34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please add [[ -f "/actions-runner/.runner" ]] && rm -f /actions-runner/.runner to deregister_runner() after ./config.sh remove ...

@bodograumann
Copy link
Contributor Author

Thanks for the quick response @myoung34 . I have incorporated your suggestions.

@bodograumann bodograumann requested a review from myoung34 October 5, 2024 18:14
@myoung34 myoung34 merged commit 47ce625 into myoung34:master Oct 6, 2024
11 checks passed
@bodograumann bodograumann deleted the patch-1 branch October 6, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myoung34 myoung34 myoung34 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ephemeral runner sometimes gets caught in a restart loop
2 participants
@bodograumann @myoung34