Filtering branch #21
Filtering branch #21
Conversation
alexminden
commented
Jul 10, 2022
alexminden
commented
- API request to filter the tags added
|
Missing:
|
|
I have added a menu that you can open and close by clicking on the parameter's button or close by clicking on the cross's button. |
|
Left to do:
|
server/server.jsx
Outdated
| data.append('c3', position.c3.toString()); | ||
| data.append('c4', position.c4.toString()); | ||
| const result = await myMizuClient.post( | ||
| "/api/taps/search?api_key=56b13329-6163-4884-afc8-b6839cd3f618&l=en&v=1", |
There was a problem hiding this comment.
@alexminden could you change this to use config.apiKey?
There was a problem hiding this comment.
Thank you for noticing this issue, I have updated the url (fbb2c1a)
There was a problem hiding this comment.
Sorry there are now some big conflicts with the main branch , but hopefully not too bad to resolve. Main point will be updating the existing endpoints for getting refill spot data, to apply the filters like you do in the added /filters-params endpoint.
Also, I want to make the filters dialog into a react component!
| function menuButtonUi() { | ||
| // Button UI | ||
| const divButton = document.createElement("div"); | ||
| divButton.id = "filter"; |
There was a problem hiding this comment.
I want to convert this file into a react component (e.g. https://github.com/mymizu/mymizu-web/blob/main/src/components/Metrics.jsx) , and seperate the styling out to a css file if possible!
Please let me know if I can explain how to approach !
| @@ -45,6 +46,38 @@ app.get("/get-initial-markers", async (req, res) => { | |||
| } | |||
| }); | |||
|
|
|||
| app.post("/filters-params", async (req, res) => { | |||
There was a problem hiding this comment.
when this get's merged, we'll need to merge with/resolve conflict with existing get-initial-taps and get-marker-moving-map endpoints!
