Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updating restApi to be union of RestApi and IRestApi #99

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nick-armstrong-helix
Copy link

Background

Large RestAPI collections can exceed AWS's cap on 500 resources per stack. In order to support large RestAPI collections the WatchApiGateway construct may not be defined in the same stack as the RestAPI resource. In these cases the existing WatchApiGateway construct cannot watch the created API gateway because it only accepts an apigw.RestApi object and not apigw.IRestApi object.

What

Support multistack RestAPI collections by allow restApi to be either a apigw.RestApi or apigw.IRestApi resource

@nick-armstrong-helix nick-armstrong-helix requested review from corrjo and a team as code owners February 28, 2024 18:45
@nick-armstrong-helix nick-armstrong-helix changed the title updating restApi to be union of RestApi and IRestApi feat: updating restApi to be union of RestApi and IRestApi Feb 28, 2024
@@ -1,6 +1,7 @@
# Changelog

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
### [0.5.141](https://github.com/myhelix/cdk-watchful/compare/v0.5.140...v0.5.141) (2024-02-13)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest tag is v0.5.203, may want to change this to be 204... I am genuinely confused how this version correlates to the npm package version as most repos use 2.29.0

https://www.npmjs.com/package/@myhelix/cdk-watchful?activeTab=versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants