Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Pocket share button #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmalarcon
Copy link

Hey! Thanks for your great app. It's very useful.

However, a "share" button I really miss in your current app is the one for Pocket .

I've added support for that service in your original app. I've tried to do my best with the SVG graphics although I'm not a designer, but I hope it's Ok with you.

I hope you want to merge this addition.

HTH.

JM.

@olets
Copy link
Collaborator

olets commented Aug 9, 2016

I love this idea of sharing on Pocket! So far, this button just saves a URL to your Pocket. Pocket already supports that function in all major browsers (Firefox, Chrome, Safari, Opera - get the apps here).

It'd be really cool if we could have a "recommend on Pocket" button that would automatically share the link to your public profile. The Pocket documentation doesn't say if their API has support for that… I've sent them an email to ask if it's possible. I'll update here as soon as they get back to me!

(Oh and the svg looks good to me:)

@jmalarcon
Copy link
Author

jmalarcon commented Aug 9, 2016

Glad you've liked it.

Well, it's just a shortcut to allow people to add something fast, directly
from the same place they have other options for sharing. For example, a lot
of people have Twitter buttons on their browsers too, but use those buttons
anyway :-)

Cheers

•••••••••••••••••••••••••••••
JOSÉ M. ALARCÓN

t: @jm_alarcon
b: jmalarcon.es
b: jasoft.org
•••••••••••••••••••••••••••••

Sent from a mobile device, please excuse brevity and possible mistakes.

@olets olets added the on hold label Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants