Fix missing keySize set when loading V1 RSA keys #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading a RSA key from an OPENSSH V1 file content the keySize was left at the default value 1024 instead of the actual key size from the loaded key material. This change makes the value correct if possible.
mwiede
approved these changes
Jan 3, 2023
norrisjeremy
approved these changes
Jan 3, 2023
kevin-sellers
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading a RSA key from an OPENSSH V1 file content the keySize was left at the default value 1024 instead of the actual key size from the loaded key material. This change makes the value correct if possible.