Make watchman settings importable

[jonespm]

The django-debug-toolbar had a fix a few years ago to make it "import safe" django-commons/django-debug-toolbar#801

This basically changed up the settings so that anything calling getenv wasn't called directly at the time. This is useful to be able to import the default attributes and configuration from a local settings

For instance this doesn't seem to be possible in (local) settings.py

collectstatic/django will either exception out about SECRET_KEY or even if this is imported after SECRET_KEY is defined then the locally defined WATCHMAN_CHECKS aren't set.

from watchman import settings as wm_settings

. . .

WATCHMAN_CHECKS = wm_settings.DEFAULT_CHECKS + ('dashboard.common.watchman.custom_checks.check_crontab', )

I think either the "constant's" could be moved to a separate constants file or the fix similar to the fix for 801 could be used. The workaround is just to redefine the the full set of DEFAULT_CHECKS locally but those "might" change in a future version and then would automatically update!

Thanks!

[mwarkentin]

Is this similar to what was discussed in #13? I'd be open to a PR to improve this - extracting into a standalone constants.py seems like it would be the simplest approach. Any downsides?

[jonespm]

I can't see any downsides. Watchman settings would import this, so anyone that current is (somehow?) importing the settings directly wouldn't be affected. Would be less changes than the refactor on toolbar.

[jonespm]

I created a simple PR for just moving out these 2 constant tuples to a separate file, tested it locally and updated the README.

[mirceaciu]

small impediment (maybe?). I just did a pip install django-watchman and this merge does not seem to be built (I don't have the separate constants file)

[jonespm]

Yeah, it looks like there hasn't been a new version released since 0.15.0 on Feb 2018...

It looked like I'd locally been installing and using this still as something like
pip install git+https://github.com/mwarkentin/django-watchman@master#egg=django-watchman

And didn't notice there wasn't a new version released yet.

GitHub

Build software better, together

GitHub is where people build software. More than 31 million people use GitHub to discover, fork, and contribute to over 100 million projects.

[mirceaciu]

my comment seems to relate to #136

[mwarkentin]

Oops, sorry about that. I'll try to get a new release out shortly!

[mwarkentin]

I've pushed django-watchman 0.16.0 to pypi.. hope that helps!