Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commits from fac8367 and onward break Docker volume mounting. #419

Closed
bernharl opened this issue Mar 1, 2022 · 4 comments
Closed

Commits from fac8367 and onward break Docker volume mounting. #419

bernharl opened this issue Mar 1, 2022 · 4 comments
Labels

Comments

@bernharl
Copy link

bernharl commented Mar 1, 2022

When mounting using sudo x11docker --network=host -i -g --share=ros --env TERM=screen-256color --hostdisplay --sudouser --verbose <container> I now get this error message from commit fac8367 and onward:

x11docker ERROR: Unknown option ros
  Parsed options:
   --network 'host' -i -g --share 'ros' --env 'TERM=screen-256color' --hostdisplay --sudouser '' --verbose '' -- '<container>'

  Type 'x11docker --help' for usage information
  Debug options: '--verbose' (full log) or '--debug' (log excerpt).
  Logfile will be: 
  Please report issues at https://github.com/mviereck/x11docker

Commits before that work as expected and mount the ros volume at /ros.

@mviereck
Copy link
Owner

mviereck commented Mar 1, 2022

Thank you for the report!
I've fixed the issue, the fix is in latest master. I'll publish a new release soon.

@bernharl
Copy link
Author

bernharl commented Mar 2, 2022

Thanks for the quick response!
The newest version 7.1.2 gives me the same error, unfortunately.

mviereck added a commit that referenced this issue Mar 2, 2022
@mviereck
Copy link
Owner

mviereck commented Mar 2, 2022

Ups, yet another bug.
I've fixed one first that removed the volume support.
But in your case it was a parsing error in the first place: option --gpu takes an optional argument, but -g (should) not. Is fixed now.

@bernharl
Copy link
Author

bernharl commented Mar 2, 2022

Great stuff, now it works!

@bernharl bernharl closed this as completed Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants