-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve D-Bus struct handling: as properties #98
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test fails, no property-signature hint for the variant-typed Property.Get yet.
This is at the service side. This fixes Get, but not GetAll or Set. General type checks for properties or methods are still missing. The implementation should be factorerd out.
ed134c0
to
e19ee5f
Compare
jreidinger
reviewed
Feb 23, 2022
lib/dbus/object.rb
Outdated
if iface.name == PROPERTY_INTERFACE && member_sym == :Get | ||
# Use the specific property type instead of the generic variant | ||
# returned by Get. | ||
# GetAll and Set still missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ruby dbus does not use common TODO:
or FIXME:
comments?
jreidinger
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responding to #97.
Before
Before this PR, the return signature for getting a property was a Variant:
With no type hint for the Ruby -> D-Bus data conversion, a property with a nontrivial type, such as STRUCT, would get returned incorrectly:
After
Now,
Property.Get
has a special case to look at the signature declared for the property itself.So a STRUCT, ieven though mplemented at the service side as an Array, gets returned as a STRUCT.