Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forgotten case: marshall Data::Array as an ARRAY #109

Merged
merged 3 commits into from
Apr 21, 2022

Conversation

mvidner
Copy link
Owner

@mvidner mvidner commented Apr 20, 2022

A fix for agama-project/agama#126 (comment)

CLI test:

busctl get-property org.opensuse.DInstaller /org/opensuse/DInstaller/Language1 org.opensuse.DInstaller.Language1 AvailableLanguages

The existing tests would only catch it if my_array was a nested array, such as aaq

mvidner added 2 commits April 20, 2022 17:21
agama-project/agama#126 (comment)
busctl get-property org.opensuse.DInstaller /org/opensuse/DInstaller/Language1 org.opensuse.DInstaller.Language1 AvailableLanguages
@coveralls
Copy link

coveralls commented Apr 20, 2022

Coverage Status

Coverage increased (+0.004%) to 92.559% when pulling 375c81d on marshall-typed-array into 6b6de6b on master.

@mvidner
Copy link
Owner Author

mvidner commented Apr 20, 2022

The user visible topic is: Service side: fix returning properties that contain arrays (on other than outermost level)

@mvidner mvidner merged commit 3faf9b9 into master Apr 21, 2022
@mvidner mvidner deleted the marshall-typed-array branch April 21, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants