Make sure DBus.type constructs a valid one #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was easy to construct an invalid signature, even for trivially bad cases. Now, make sure `DBus.type` constructs a valid Single Complete Type, and add `DBus.types` for constructing a valid Signature (0 or more SCTs). Add test cases. The corresponding section of the specification is https://dbus.freedesktop.org/doc/dbus-specification.html#type-system Also, `DBus::Type` was an internal Module and the constructed Class was awkwardly named `DBus::Type::Type`. Merged them (with a compatibility "symlink")
mvidner
force-pushed
the
avoid-type-type
branch
from
c5fd8f1 to
d0fd929
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subtask of #103 but it is separate enough to make sense as a standalone PR.
Previously it was easy to construct an invalid signature, even for trivially bad cases.
Now, make sure
DBus.typeconstructs a valid Single Complete Type, and addDBus.typesfor constructing a valid Signature (0 or more SCTs)Add test cases.
The corresponding section of the specification is Type System
Also,
DBus::Typewas an internal Module and the constructed Class was awkwardly namedDBus::Type::Type. Merged them (with a compatibility "symlink")