Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failure #129

Merged
merged 4 commits into from
Oct 18, 2022
Merged

Fix CI failure #129

merged 4 commits into from
Oct 18, 2022

Conversation

notgull
Copy link
Contributor

@notgull notgull commented Oct 10, 2022

No description provided.

@zesterer
Copy link
Collaborator

Looks like there's still a failure :( https://github.com/mvdnes/spin-rs/actions/runs/3220728435/workflow

@notgull
Copy link
Contributor Author

notgull commented Oct 17, 2022

MIRI appears to be failing due to one of the tests leaving a thread hanging before exiting. This can be fixed by adding a sleep operation to the end of the offending test to give it time to catch up.

@zesterer
Copy link
Collaborator

Do you happen to know which test is failing?

@notgull
Copy link
Contributor Author

notgull commented Oct 17, 2022

Not sure, I just set it up to ignore threading leaks for the time being.

@zesterer
Copy link
Collaborator

Thanks, I think that's satisfactory for now. This is still a substantial improvement, so thanks!

@zesterer zesterer merged commit 8181441 into mvdnes:master Oct 18, 2022
@notgull notgull deleted the ci branch October 18, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants