Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interp: set EUID #958

Merged
merged 2 commits into from
Dec 21, 2022
Merged

interp: set EUID #958

merged 2 commits into from
Dec 21, 2022

Conversation

anderbubble
Copy link
Contributor

Set EUID variable analog to UID.

Signed-off-by: Jonathon Anderson [email protected]

@anderbubble
Copy link
Contributor Author

This is meant to be a better fix for apptainer/apptainer#837 than is possible downstream. (e.g., apptainer/apptainer#937)

Copy link
Owner

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to use https://pkg.go.dev/os#Geteuid?

Set EUID variable analog to UID.

Signed-off-by: Jonathon Anderson <[email protected]>
@anderbubble
Copy link
Contributor Author

Absolutely. I was just too far down my downstream thought process, where we had been planning to set EUID=$UID in a script. Thanks for pointing this out.

PR updated.

Copy link
Owner

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, thanks. Add a couple of tests mirroring the existing ones for UID? I think one test and one unset test should be enough.

Signed-off-by: Jonathon Anderson <[email protected]>
@anderbubble
Copy link
Contributor Author

@mvdan how about these?

@mvdan mvdan merged commit d3feb15 into mvdan:master Dec 21, 2022
@anderbubble
Copy link
Contributor Author

Thanks for the merge!

Do you have an estimate for when this might be included in a release?

@mvdan
Copy link
Owner

mvdan commented Dec 28, 2022

I'll probably do a bugfix release in the coming weeks. I just did a minor (feature) release, so that likely won't happen again for a few months. If you need this sooner, you should be able to use master.

@DrDaveD
Copy link

DrDaveD commented Dec 28, 2022

So, would you include this in a bugfix release?

@mvdan
Copy link
Owner

mvdan commented Jan 5, 2023

Sure, why not. It doesn't feel too risky. Though, again, you should be able to use master easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants