-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
interp: set EUID #958
interp: set EUID #958
Conversation
This is meant to be a better fix for apptainer/apptainer#837 than is possible downstream. (e.g., apptainer/apptainer#937) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you mean to use https://pkg.go.dev/os#Geteuid?
Set EUID variable analog to UID. Signed-off-by: Jonathon Anderson <[email protected]>
Absolutely. I was just too far down my downstream thought process, where we had been planning to set EUID=$UID in a script. Thanks for pointing this out. PR updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM, thanks. Add a couple of tests mirroring the existing ones for UID? I think one test
and one unset
test should be enough.
Signed-off-by: Jonathon Anderson <[email protected]>
@mvdan how about these? |
Thanks for the merge! Do you have an estimate for when this might be included in a release? |
I'll probably do a bugfix release in the coming weeks. I just did a minor (feature) release, so that likely won't happen again for a few months. If you need this sooner, you should be able to use master. |
So, would you include this in a bugfix release? |
Sure, why not. It doesn't feel too risky. Though, again, you should be able to use master easily. |
Set EUID variable analog to UID.
Signed-off-by: Jonathon Anderson [email protected]