revamp //gofumpt:diagnose for real use cases #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Drat, Go 1.17. I will temporarily disable the VCS stuff until Go 1.19 is released and we drop 1.17. |
|
Hm, that would be a larger refactor than I thought. I'll instead wait for 1.19 to be out, then drop 1.17, then rebase this to get it green. |
Oiyoo
approved these changes
Aug 3, 2022
Right now, it simply reports "(devel)" as the gofumpt version when gofumpt is used as a library via the format package, which is the case for many users like golangci-lint. To properly test this behavior, we add a gofumpt-external program which simply formats stdin with one option and prints to stdout. We `go install` this tool, which depends on a released gofumpt version. It also does not report the Go version, which is important as we rely on packages like go/printer, which can influence our behavior. Similar to the case above, we `go install` a released gofumpt version. It also does not use VCS information when it is the main module; add that as well, along with a test, borrowed from mvdan.cc/garble. While here, make the output easier to read by adding "version" and "flags" words as descriptions. Finally, we remove version.Print, which was an unnecessary wrapper. The following PR will update the released version of gofumpt being used, meaning that the "released" and "external" tests will pick up the improvement.
|
Rebased, should be green now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)