Small optimizations #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/michaelvasin/react-div-100vh/9rfb72gi0 |
reference https://reactjs.org/docs/hooks-reference.html#functional-updates “If your update function returns the exact same value as the current state, the subsequent rerender will be skipped completely.” Signed-off-by: KATT <[email protected]>
KATT
commented
Sep 25, 2020
| @@ -23,7 +23,7 @@ export default function Div100vh({ | |||
| } | |||
|
|
|||
| export function use100vh(): number | null { | |||
| const [height, setHeight] = useState<number | null>(measureHeight()) | |||
| const [height, setHeight] = useState<number | null>(measureHeight) | |||
There was a problem hiding this comment.
KATT
commented
Sep 25, 2020
| @@ -32,12 +32,12 @@ export function use100vh(): number | null { | |||
|
|
|||
| function setMeasuredHeight() { | |||
| const measuredHeight = measureHeight() | |||
| if (height !== measuredHeight) setHeight(measuredHeight) | |||
| setHeight(measuredHeight) | |||
There was a problem hiding this comment.
https://reactjs.org/docs/hooks-reference.html#functional-updates
If your update function returns the exact same value as the current state, the subsequent rerender will be skipped completely.
KATT
commented
Sep 25, 2020
| } | ||
|
|
||
| window.addEventListener('resize', setMeasuredHeight) | ||
| return () => window.removeEventListener('resize', setMeasuredHeight) | ||
| }, [height, wasRenderedOnClientAtLeastOnce]) |
There was a problem hiding this comment.
skips adding/removing event listener on every resize
KATT
commented
Sep 25, 2020
Comment on lines
59
to
-63
| useEffect(() => { | ||
| if (isClient() && !wasRenderedOnClientAtLeastOnce) { | ||
| if (isClient()) { | ||
| setWasRenderedOnClientAtLeastOnce(true) | ||
| } | ||
| }, [wasRenderedOnClientAtLeastOnce]) |
There was a problem hiding this comment.
|
Looks good to me, thanks @KATT! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
measureHeight()on every render - referencereference