Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Amazon S3 provider #121

Merged
merged 1 commit into from
Dec 18, 2023
Merged

feat: add Amazon S3 provider #121

merged 1 commit into from
Dec 18, 2023

Conversation

luwes
Copy link
Collaborator

@luwes luwes commented Dec 12, 2023

Amazon made some security changes recently which made the implementation more difficult
https://aws.amazon.com/blogs/aws/heads-up-amazon-s3-security-changes-are-coming-in-april-of-2023/

it's not 1 to 1 anymore with Backblaze but still very similar.

@luwes luwes self-assigned this Dec 12, 2023
@luwes luwes requested a review from heff December 12, 2023 14:46
Copy link
Contributor

@heff heff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. 👍 I don't have a way to test live currently but no issues with the shape I'm seeing.

| Pricing | Minutes-based | GB-based | GB-based | GB-based |


## Required Permissions for Amazon S3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's an annoying step. I'd love to have this in a different doc rather than cluttering up the readme... but we can save that for a future docs build.

@luwes luwes merged commit 1d56169 into muxinc:main Dec 18, 2023
2 checks passed
@luwes luwes deleted the amazon-s3 branch December 18, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants