Added ability to change context menu icon color #26288
Merged
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eism
reviewed
Jan 31, 2025
Eism
approved these changes
Jan 31, 2025
grliszas14
force-pushed
the
change_icon_color
branch
from
6dde068 to
b7c9de4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds possibility to change context menu icon color like this:
Used QString instead of QColor as the latter loses "invalid" property once converted to color property in QML - QML then treats it as a perfectly valid black color.
That way, in case of not providing a custom color, icon will stay as it was assuming fontPrimaryColor.
QA note:
Result should not impact MuseScore's context menu icons (or top bar menu)