FIX(client, theme): Chinese characters not displayed properly (scss modified) #6200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds some font families to the default themes that improve the displaying of Chinese characters. Added Windows(Microsoft YaHei), Linux(Noto Sans SC), Mac(PingFang SC) default Chinese fonts in the default theme's font-family, which can avoid the system calling fonts such as Simsun by default and bring bad display effect. I put it in front of Arial and sans-serif, and behind other fonts, so as to avoid affecting the display of non-CJK fonts on the operating system.
1 task
Krzmbrzl
approved these changes
Dec 30, 2023
There was a problem hiding this comment.
LGTM
@Hartmnt I checked the stringification of boolean values and it seems like different Sass implementations handle this differently. E.g. ruby-sass adds quotes (and also makes additional formatting changes) whereas the (seemingly) official reference implementation written in Dart as well as the Node.js package (which I think is simply a transpiled version of the Dart implementation) remove the quotes.
Thus, I think not having the quotes is fine and since that's what the reference implementation does in its latest release, I think we can try to stick to that.
|
@alpzmj9 thank you for fixing this and sorry for the long response time of mine 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds some font families to the default themes that improve the displaying of Chinese characters.
Added Windows(Microsoft YaHei), Linux(Noto Sans SC), Mac(PingFang SC) default Chinese fonts in the default theme's font-family, which can avoid the system calling fonts such as Simsun by default and bring bad display effect. I put it in front of Arial and sans-serif, and behind other fonts, so as to avoid affecting the display of non-CJK fonts on the operating system.
I modified the scss code as requested, and I'm sorry to restart a pull request again because I'm not familiar with using git yet.
Checks