Started Issue #5370 with UI for Server Logs #5915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 4, 2022 22:16
Began the UI for the server logs feature desired in issue mumble-voip#5370. This will later be changed to implement the log database and the protocol buffer.
Implemented UI for server logs and added to MainWindow files and CMakeLists.txt.
Fixed Git rebasing issues in code.
Krzmbrzl
requested changes
Oct 13, 2022
| @@ -1163,4 +1166,4 @@ endif() | |||
|
|
|||
| target_include_directories(${TARGET_NAME} INTERFACE | |||
| $<BUILD_INTERFACE:${AUTOGEN_INCLUDE_DIR}> | |||
| ) | |||
| ) | |||
| @@ -3774,4 +3782,4 @@ void MainWindow::destroyUserInformation() { | |||
| return; | |||
| } | |||
| } | |||
| } | |||
| } | |||
| @@ -38,6 +38,7 @@ class UserInformation; | |||
| class VoiceRecorderDialog; | |||
| class PositionalAudioViewer; | |||
| class PTTButtonWidget; | |||
| class ServerLogs; | |||
There was a problem hiding this comment.
What is this forward-declaration needed for?
| @@ -380,4 +382,4 @@ public slots: | |||
| void logChangeNotPermanent(const QString &actionName, ClientUser *const p) const; | |||
| }; | |||
|
|
|||
| #endif | |||
| #endif | |||
Comment on lines
+7
to
+14
| #include "MainWindow.h" | ||
| #include "ServerHandler.h" | ||
| #include "Version.h" | ||
| #include "Global.h" | ||
|
|
||
| #include <QTableWidgetItem> | ||
|
|
||
| #include <boost/accumulators/accumulators.hpp> |
There was a problem hiding this comment.
These seem to have been introduced by copy&pasting from somewhere else and can be removed (unless those you actually need)
| @@ -0,0 +1,38 @@ | |||
| // Copyright 2021-2022 The Mumble Developers. All rights reserved. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2021-2022 The Mumble Developers. All rights reserved. | |
| // Copyright 2022 The Mumble Developers. All rights reserved. |
| @@ -0,0 +1,32 @@ | |||
| // Copyright 2021-2022 The Mumble Developers. All rights reserved. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2021-2022 The Mumble Developers. All rights reserved. | |
| // Copyright 2022 The Mumble Developers. All rights reserved. |
Krzmbrzl
added
client
ui
feature-request
|
@AmaniN16 do you have any plans on continuing on this PR? |
|
Closing as abandoned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started with creating the display window for the server logs requested in issue #5370 and also added this to the server dropdown on the main window. Changes were made in the MainWindow files and the CMakeLists.txt and ServerLogs.ui, ServerLogs.cpp, and ServerLogs.h were created. The database still needs to be referenced and the Protocol Buffer needs to be created as well.
Server Logs Window in QT Designer
Checks