Sovereign Chains Cross-Chain Execution #1033

andreiblt1304 · 2025-01-14T12:51:10Z

Description of the pull request (what is new / what has changed)

Did you test the changes locally ?

yes
no

Which category (categories) does this pull request belong to?

document new feature
update documentation that is not relevant anymore
add examples or more information about a component
fix grammar issues
other

schimih · 2025-01-14T14:19:18Z

docs/sovereign/cross-chain-example.md

@@ -0,0 +1,9 @@
+# Cross-Chain Execution Example


Where is this linked to the docs?

schimih · 2025-01-14T14:22:06Z

docs/sovereign/cross-chain-execution.md

@@ -0,0 +1,18 @@
+# Creating Bridges


This title is confusing. Creating bridges between what to what should be the answer? At this point in time, a normal user, first time visitor will have no clue to what kind of bridges we are reffering to. Even though we may think that it is obvious (it may be for us) that the topic of this page is the bridge btw MainChain to Sovereign and the other way around, it is not.

schimih · 2025-01-14T14:23:41Z

docs/sovereign/cross-chain-execution.md

+
+## What is Cross-Chain Execution?
+
+Being able to connect 2 different ecosystems opens up infinite possibilities for functionality. Cross-Chain Execution implies using the functionality of two different chains and combining both of them. In this context we can refer to: 


same thing as above:

A new user will ask himself:
"two chains" - Is it Ethereum and Solana? or what chains are you referring to?

schimih · 2025-01-14T14:24:32Z

docs/sovereign/cross-chain-execution.md

+
+Being able to connect 2 different ecosystems opens up infinite possibilities for functionality. Cross-Chain Execution implies using the functionality of two different chains and combining both of them. In this context we can refer to: 
+
+1. Sending tokens from one chain to another


Same as above.

Better define from what Chain to what Chain. Probably it will be better to have a note above where you define what MainChain is and what Sovereign Chain is.

schimih · 2025-01-14T14:25:10Z

docs/sovereign/cross-chain-execution.md

+
+## Cross-Chain Execution within Sovereign Chains
+
+All the heavy lifting is being done by the *ESDT-Safe* Smart Contract. 


where is this Smart Contract described in detail? if it is not, let's create a page for it. If it is, add a link to that description.

schimih · 2025-01-14T14:26:32Z

docs/sovereign/to-sovereign.md

@@ -0,0 +1,42 @@
+# To Sovereign


To sovereign but from where? From another Sovereign or From Mainchain?

schimih · 2025-01-14T14:31:03Z

static/sovereign/ToSovereign.png

This is not clear enough.

Please modify.

Split in two main part -> what is part of MainChain, what is part of Sovereign.

Besides the ESDT-Safe and Token-Handler contracts (where is token handler described and what's it's purpose) I do not know what the other symbols represent. The first user is Alice who is sending to her on the same chain or is it a differnet chain? etc etc.

schimih · 2025-01-14T14:32:30Z

static/sovereign/FromSovereign.png

This is not clear enough.

docs/sovereign/cross-chain-execution.md

docs/sovereign/to-sovereign.md

docs/sovereign/from-sovereign.md

Signed-off-by: Andrei Baltariu <[email protected]>

docs/sovereign/to-sovereign.md

docs/sovereign/from-sovereign.md

docs/sovereign/to-sovereign.md

static/sovereign/from-sovereign.png

static/sovereign/to-sovereign.png

Signed-off-by: Andrei Baltariu <[email protected]>

docs/sovereign/to-sovereign.md

docs/sovereign/from-sovereign.md

Signed-off-by: Andrei Baltariu <[email protected]>

axenteoctavian · 2025-02-06T12:04:06Z

docs/sovereign/cross-chain-execution.md

+This feature is enabled by using multiple smart contracts, each one with its unique role and set of functionalities. The current Sovereign Chain suite consists of three main contracts, here is the high-level description for some of the cross chain smart contracts:
+
+#### ESDT-Safe
+The *ESDT-Safe* Smart Contract performs all the heavy lifting. This is the cross-chain execution contract, this execution will be done between either any Sovereign Chain and the MultiversX mainchain or between any Sovereign Chains.


"cross-chain execution contract" - the contract does not execute anything cross-chain. It's responsible for the cross-chain transfers

"between any Sovereign Chains" - not true

axenteoctavian · 2025-02-06T12:12:02Z

docs/sovereign/cross-chain-execution.md

+#### ESDT-Safe
+The *ESDT-Safe* Smart Contract performs all the heavy lifting. This is the cross-chain execution contract, this execution will be done between either any Sovereign Chain and the MultiversX mainchain or between any Sovereign Chains.
+
+There are two modules implemented for this contract: [*From Sovereign*](from-sovereign.md), [*To Sovereign*](to-sovereign.md) and two important endpoints: [`execute_operation`](from-sovereign.md#executing-an-operation), [`deposit`](to-sovereign.md#deposit-tokens). Both of them allow the caller to transfer tokens and also execute smart contracts within a single transaction. The only difference is where the sender and receiver of the cross-chain execution are situated. 


Both of them allow the caller to transfer tokens and also execute smart contracts within a single transaction. The only difference is where the sender and receiver of the cross-chain execution are situated.

This is not really accurate. Users only use the deposit endpoint to deposit tokens which will be transferred cross-chain. The other endpoint is used only for transfers sov -> main by the bridge service

axenteoctavian · 2025-02-06T12:12:47Z

docs/sovereign/cross-chain-execution.md

+
+The scenarios for what endpoint to choose look like this:
+1. If the receiver is in a Sovereign Chain, the call should be to the `deposit` endpoint. (_To Sovereign_) 
+2. If the sender is in a Sovereign Chain, the call should be to the `execute_operation` endpoint. (_From Sovereign_)


The call is also on deposit endpoint, then the bridge service will execute_operation on main chain

axenteoctavian · 2025-02-06T12:13:56Z

docs/sovereign/cross-chain-execution.md

+Cross-Chain execution is the ability of smart contracts or decentralized applications on one blockchain to invoke actions on another blockchain. This feature allows for seamless communication and interaction between different blockchain networks, enabling developers to build applications that are chain agnostic.
+
+
+## Cross-Chain Execution within Sovereign Chains


I would say we need to add some context about the bridge service because it's needed for my next comments

axenteoctavian · 2025-02-06T12:15:31Z

docs/sovereign/cross-chain-execution.md

+:::
+
+#### Fee-Market
+Since every Sovereign Chain will have a customizable fee logic, it was paramount that this configuration had to be separated into a different contract. Rules such as: fee token, fee percentages, whitelists are all stored inside this contract.


rules are: fee per transferred token, fee per gas unit and users whitelist to bypass the fee

you can also add that this contract is present in both chains

axenteoctavian · 2025-02-06T12:25:59Z

docs/sovereign/cross-chain-execution.md

+All the *BLS keys* of the validator will be stored inside this contract. The main role for the Header-Verifier contract is to verify signatures for the operations that are created inside the Sovereign Chain.
+
+:::note
+Each Sovereign Chain will include those smart contracts, the source code can be found at the official [MultiversX Sovereign Chain SCs repository](https://github.com/multiversx/mx-sovereign-sc). 


Suggested change

Each Sovereign Chain will include those smart contracts, the source code can be found at the official [MultiversX Sovereign Chain SCs repository](https://github.com/multiversx/mx-sovereign-sc).

The source code for the smart contracts can be found at the official [MultiversX Sovereign Chain SCs repository](https://github.com/multiversx/mx-sovereign-sc).

axenteoctavian · 2025-02-06T12:36:35Z

docs/sovereign/cross-chain-execution.md

+Since every Sovereign Chain will have a customizable fee logic, it was paramount that this configuration had to be separated into a different contract. Rules such as: fee token, fee percentages, whitelists are all stored inside this contract.
+
+#### Header-Verifier
+All the *BLS keys* of the validator will be stored inside this contract. The main role for the Header-Verifier contract is to verify signatures for the operations that are created inside the Sovereign Chain.


I would say this with more context, like
main role is to verify operations - operations are signed by validators - if succesfully verified will be registered and can be executed by ESDT-Safe

Signed-off-by: Andrei Baltariu <[email protected]>

andreiblt1304 marked this pull request as ready for review January 14, 2025 12:55

schimih requested changes Jan 14, 2025

View reviewed changes

andreiblt1304 changed the base branch from main to development January 15, 2025 08:04

andreiblt1304 changed the base branch from development to main January 15, 2025 08:08

axenteoctavian requested changes Jan 15, 2025

View reviewed changes

andreiblt1304 self-assigned this Jan 15, 2025

andreiblt1304 changed the base branch from main to development January 16, 2025 07:40

andreiblt1304 added 16 commits January 16, 2025 10:09

Added Cross-Chain Execution docs

f0ca287

Signed-off-by: Andrei Baltariu <[email protected]>

Removed some info and added page to sidebars.js

8c4045b

Signed-off-by: Andrei Baltariu <[email protected]>

Renamed file and added separate category

d8c1948

Signed-off-by: Andrei Baltariu <[email protected]>

Typo fix

00040de

Signed-off-by: Andrei Baltariu <[email protected]>

Removed example page

4d2092c

Signed-off-by: Andrei Baltariu <[email protected]>

Added description for main SCs

f7aae1c

Signed-off-by: Andrei Baltariu <[email protected]>

Renamed title for to-sovereign file

68a68c2

Signed-off-by: Andrei Baltariu <[email protected]>

Renamed title for from-sovereign file

5af921e

Signed-off-by: Andrei Baltariu <[email protected]>

Made first Cross-Chain execution page more clear

6f7c324

Signed-off-by: Andrei Baltariu <[email protected]>

Updated photos

b9f9346

Signed-off-by: Andrei Baltariu <[email protected]>

Fixes after review

fbf6d13

Signed-off-by: Andrei Baltariu <[email protected]>

Typos

dccc49c

Signed-off-by: Andrei Baltariu <[email protected]>

Fixes after review

463a9f5

Signed-off-by: Andrei Baltariu <[email protected]>

Added Header-Verifier documentation

902bfa1

Signed-off-by: Andrei Baltariu <[email protected]>

Updated diagrams

eef67bb

Signed-off-by: Andrei Baltariu <[email protected]>

More fixes

9ecd4a6

Signed-off-by: Andrei Baltariu <[email protected]>

andreiblt1304 force-pushed the cross-execution branch from 13dcbed to 9ecd4a6 Compare January 16, 2025 08:09

axenteoctavian requested changes Jan 16, 2025

View reviewed changes

andreiblt1304 added 2 commits January 16, 2025 23:18

Fix after review

f6a9cfc

Signed-off-by: Andrei Baltariu <[email protected]>

Spell checker

0f981e1

Signed-off-by: Andrei Baltariu <[email protected]>

axenteoctavian requested changes Jan 17, 2025

View reviewed changes

docs/sovereign/to-sovereign.md Outdated Show resolved Hide resolved

docs/sovereign/from-sovereign.md Outdated Show resolved Hide resolved

Fixes after review

0c1cc40

Signed-off-by: Andrei Baltariu <[email protected]>

axenteoctavian previously approved these changes Jan 17, 2025

View reviewed changes

andreiblt1304 added 5 commits February 5, 2025 09:20

Merge branch 'development' into cross-execution

19a4028

Modified introduction

5eec40f

Signed-off-by: Andrei Baltariu <[email protected]>

Modified introduction

41d3cae

Signed-off-by: Andrei Baltariu <[email protected]>

Moved the ESDT-Safe contract at the top

d7eaea7

Signed-off-by: Andrei Baltariu <[email protected]>

Modified from-sovereign docs

12ad601

Signed-off-by: Andrei Baltariu <[email protected]>

andreiblt1304 dismissed axenteoctavian’s stale review via 12ad601 February 5, 2025 13:59

axenteoctavian reviewed Feb 6, 2025

View reviewed changes

andreiblt1304 added 2 commits February 7, 2025 12:35

Fix after review

0f7fcfa

Signed-off-by: Andrei Baltariu <[email protected]>

Typo

d12a4ce

Signed-off-by: Andrei Baltariu <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sovereign Chains Cross-Chain Execution #1033

Sovereign Chains Cross-Chain Execution #1033

andreiblt1304 commented Jan 14, 2025 •

edited

Loading

schimih Jan 14, 2025

schimih Jan 14, 2025

schimih Jan 14, 2025

schimih Jan 14, 2025

schimih Jan 14, 2025

schimih Jan 14, 2025

schimih Jan 14, 2025

schimih Jan 14, 2025

axenteoctavian Feb 6, 2025

axenteoctavian Feb 6, 2025

axenteoctavian Feb 6, 2025

axenteoctavian Feb 6, 2025

axenteoctavian Feb 6, 2025

axenteoctavian Feb 6, 2025

axenteoctavian Feb 6, 2025


		## What is Cross-Chain Execution?

		Being able to connect 2 different ecosystems opens up infinite possibilities for functionality. Cross-Chain Execution implies using the functionality of two different chains and combining both of them. In this context we can refer to:


		Being able to connect 2 different ecosystems opens up infinite possibilities for functionality. Cross-Chain Execution implies using the functionality of two different chains and combining both of them. In this context we can refer to:

		1. Sending tokens from one chain to another


		## Cross-Chain Execution within Sovereign Chains

		All the heavy lifting is being done by the ESDT-Safe Smart Contract.

		Cross-Chain execution is the ability of smart contracts or decentralized applications on one blockchain to invoke actions on another blockchain. This feature allows for seamless communication and interaction between different blockchain networks, enabling developers to build applications that are chain agnostic.


		## Cross-Chain Execution within Sovereign Chains

	Each Sovereign Chain will include those smart contracts, the source code can be found at the official [MultiversX Sovereign Chain SCs repository](https://github.com/multiversx/mx-sovereign-sc).
	The source code for the smart contracts can be found at the official [MultiversX Sovereign Chain SCs repository](https://github.com/multiversx/mx-sovereign-sc).

Sovereign Chains Cross-Chain Execution #1033

Are you sure you want to change the base?

Sovereign Chains Cross-Chain Execution #1033

Conversation

andreiblt1304 commented Jan 14, 2025 • edited Loading

Description of the pull request (what is new / what has changed)

Did you test the changes locally ?

Which category (categories) does this pull request belong to?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andreiblt1304 commented Jan 14, 2025 •

edited

Loading