This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
Add setup for Testnet. Optimize sync time #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianpascalau
previously approved these changes
Nov 13, 2023
| network = parsed_args.network | ||
| data = toml.load(file) | ||
|
|
||
| if network == "testnet": |
There was a problem hiding this comment.
refactored L18-L76 in a new function with early exits and removed else / elif branches?
There was a problem hiding this comment.
Fixed (refactored).
ssd04
previously approved these changes
Nov 13, 2023
Dockerfile
Outdated
Comment on lines
64
to
66
| WORKDIR /go/mx-chain-proxy-go-mainnet/cmd/proxy | ||
| RUN go build | ||
|
|
There was a problem hiding this comment.
not related to these changes, maybe in a future PR; we have also for proxy appVersion and commitID based on build data, so it can be build like this -ldflags="-X main.appVersion=$(git --git-dir /workspace/mx-chain-devnet-config/.git describe --tags --long --dirty) -X main.commitID=$(git --git-dir /workspace/mx-chain-devnet-config/.git rev-parse HEAD)"
There was a problem hiding this comment.
Partially fixed - appVersion, but without commitID - just as for the Node.
andreibancioiu
dismissed stale reviews from ssd04 and iulianpascalau
via
8f2ddc8
ssd04
approved these changes
Nov 15, 2023
iulianpascalau
approved these changes
Nov 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize sync time:
Define setup for Testnet in docker-compose. Omit "re-construction services", since they will be removed here anyway:
Use
prefs.tomloverrides, where possible.