Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update branch references #290

Merged
merged 2 commits into from
May 13, 2024
Merged

Conversation

mjmartineau
Copy link
Member

@mjmartineau mjmartineau commented May 13, 2024

The default branch name is now 'main' (see #289), so the Coveralls badge URLs and Github actions need to reference that branch name.

The default branch name is now 'main' (see multipath-tcp#289), so the Coveralls
badge URLs need to reference that branch name.
@mjmartineau mjmartineau requested a review from matttbe May 13, 2024 17:27
@coveralls
Copy link

coveralls commented May 13, 2024

Pull Request Test Coverage Report for Build 9068362784

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.777%

Totals Coverage Status
Change from base Build 9066977988: 0.0%
Covered Lines: 1394
Relevant Lines: 2152

💛 - Coveralls

Copy link
Member

@matttbe matttbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for having handled that!

Copy link
Member

@matttbe matttbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the references to master in .github/workflows as well please?

Trigger actions on push or PR for the 'main' branch.
@mjmartineau mjmartineau changed the title README: Update branch references in badge URLs Update branch references May 13, 2024
Copy link
Member

@matttbe matttbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update!

@mjmartineau mjmartineau merged commit 5eea3f4 into multipath-tcp:main May 13, 2024
6 checks passed
@mjmartineau mjmartineau deleted the rename-to-main branch May 13, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants