Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix build is currently broken #247

Closed
vmx opened this issue Nov 10, 2022 · 3 comments · Fixed by #254
Closed

Nix build is currently broken #247

vmx opened this issue Nov 10, 2022 · 3 comments · Fixed by #254

Comments

@vmx
Copy link
Member

vmx commented Nov 10, 2022

Currently the nix instructions are broken, likely due to using an arbitrary nightly version of Rust.

@Anderssorby @samuelburnham you were involved in setting it up. Could you please have a look?

@Anderssorby
Copy link
Contributor

I recommend switching to using fenix.

@vmx
Copy link
Member Author

vmx commented Nov 10, 2022

How much trouble would it be to have the Cargo.lock and nix information outside the repo? To me it would make things easier without them, but I also don't want the lives of people caring about nix harder.

@Anderssorby
Copy link
Contributor

It would be a lot of trouble if using nixos which expects declarative environments. Nix-cargo-integration is another option.

vmx added a commit that referenced this issue Dec 5, 2022
The Nix support isn't really maintained, hence remove it to reduce
the maintenance burden.

The `Cargo.lock` file was only introduced for the Nix build, it's
now removes as well as `multihash` is a library, which usually
don't have lock files.

Closes #247.
@vmx vmx closed this as completed in #254 Dec 5, 2022
vmx added a commit that referenced this issue Dec 5, 2022
The Nix support isn't really maintained, hence remove it to reduce
the maintenance burden.

The `Cargo.lock` file was only introduced for the Nix build, it's
now removes as well as `multihash` is a library, which usually
don't have lock files.

Closes #247.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants