Improving test coverage #6
Conversation
|
Seems I added travis after and didn't notice I added 0.4 instead of 4 for the Node.js version. Mind rebasing so that travis runs the tests again? update: nvm on Travis, seems it is having problems with installing buffertools |
| }) | ||
| }) | ||
|
|
||
| test('closing socket for unsupported handler', function (done) { |
There was a problem hiding this comment.
where is the check to see if the socket is closed?
|
Hey @vsukhomlinov, thank you for the PR. I'm missing to see how this fixes #5, could you point me to that line? |
|
It doesn't. It fixes #5 from another repository. -Vitaly
|
| @@ -2,6 +2,15 @@ language: node_js | |||
| node_js: | |||
| - "4" | |||
| - "5" | |||
| env: | |||
| - CXX=g++-4.8 #need that for the buffertools dependency | |||
|
Closing in favour of #9 Thank you for bringing this @vsukhomlinov |
Fixes libp2p/js-libp2p#5