Bad publish bump #73
Merged
Bad publish bump #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤦 this triggered a semver-major, I have no idea why when the last one didn't, but I've also discovered by checking the logs that the published failed but tag succeeded in the patch release that I was trying to fix! I don't think there's an exit code code check in the publish script. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#70 failed to bump major, it was interpreted as a patch and it's very breaking so this is a quick revert of the patch set for another patch release, then I'll add back the changes for a proper major bump. (publish access is limited here so I have to rely on the action to get this done FYI)