fix Read assumptions #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read can return 1, io.EOF on end of file. According to the ByteReader interface, we should be returning the byte read along with a nil error in this case. Also, handle the short-read case by returning the appropriate error.
Stebalien
commented
Mar 8, 2018
| @@ -421,22 +419,22 @@ func lpReadBuf(r io.Reader) ([]byte, error) { | |||
|
|
|||
| } | |||
|
|
|||
| type byteReaderIface interface { | |||
There was a problem hiding this comment.
Got rid of this as we don't really need it.
Kubuxu
approved these changes
Mar 8, 2018
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read can return 1, io.EOF on end of file. According to the ByteReader interface, we should be returning the byte read along with a nil error in this case.
Also, handle the short-read case by returning the appropriate error.